[Xen-devel] Re: [patch 02/28]xen: Add nosegneg capability to the vsyscall page notes

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Roland McGrath wrote:
>> + * It should contain:
>> + *  hwcap 0 nosegneg
>> + * to match the mapping of bit to name that we give here.
>>     
>
> This comment still needs s/0/1/ to match the code.  Given that the actual
> bit is now defined in the macro in another file, perhaps the comment should
> say more about it than just a magic 1.
>   

Crap, I thought I had 1) understood it, and 2) fixed it.  I guess I
skipped 1 and therefore overlooked 2.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel