Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, May 16, 2007 at 04:31:33PM +0900, Simon Horman wrote:
> On Wed, May 16, 2007 at 08:21:41AM +0100, Keir Fraser wrote:
> > 
> > 
> > 
> > On 16/5/07 07:49, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:
> > 
> > > Curiously, making xen_max_nr_phys_cpus __init causes a section missmatch
> > > error at compile time. I guess this is to do with the way global ints
> > > are handled. I confirmed that its consistent across x86_32, x86_64 and
> > > ia64. So I guess its ok to leave it as is.
> > 
> > What if you make it __initdata, as it (and the other data variables) should
> > be?
> 
> I'll take a look into that and get back to you.

That ideed does solve the problem, silly me.
I'll send an updated patch in a moment.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel