RE: [Xen-devel] new_ctxt_format in xc_linux_restore?

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年5月21日 14:27
>
>On 21/5/07 06:37, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> Guess following lines as typo since new context format is used to
>> support fast suspend with online vcpu context saved in image file:
>>
>> if ( !new_ctxt_format ) <--- Opposite should be used here???
>>     ctxt.flags |= VGCF_online;
>>
>> Or do I misunderstand save/restore logic? Also interested why
>> smp restore works if a true typo above. :-)
>
>It's the right way round. Old images may not include the VGCF_online
>flag
>(since it is a new flag). Since old images only ever include one saved
>VCPU,
>and that VCPU is never offline, we just poke that flag in.
>
> -- Keir

Oh, I see. I didn't note that VGCF_online has been saved for all 
online cpus at suspend phase. This line is just specific to BSP of 
old format.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel