[Xen-devel] RE: [Xen-staging] [xen-unstable] Add persistent guest & hv logging inxenconsoled.

["Christian Limpach" <Christian.Limpach@xxxxxxxxxxxxx>]

> # HG changeset patch
> # User kfraser@xxxxxxxxxxxxxxxxxxxxx
> # Date 1180964952 -3600
> # Node ID edf407a3dd70db0af60617b6c90aa3589d7c1c7d
> # Parent  da3185b03113611fd322e439f17103af4d11b064
> Add persistent guest & hv logging in xenconsoled.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

> +     namepath = xs_get_domain_path(xs, dom->domid);
> +     s = realloc(namepath, strlen(namepath) + 6);
> +     if (s == NULL) {
> +             free(namepath);
> +             return -1;
> +     }
> +     strcat(namepath, "/name");
> +     data = xs_read(xs, XBT_NULL, namepath, &len);

Isn't this missing namepath = s?

> -             ret = select(max_fd + 1, &readfds, &writefds, 0, NULL);
> +             /* XXX I wish we didn't have to busy wait for 
> hypervisor logs
> +              * but there's no obvious way to get event 
> channel notifications
> +              * for new HV log data as we can with guest */

Isn't that what the VIRQ_CON_RING virq was added for?  See changeset:
# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1173367270 0
# Node ID 38513d22d23420a90f94e7e0f70c564100e83851
# Parent  90e8d8169afd8acdd33e262012a8098cd3f8c944
xen: Provide notification of console updates via VIRQ.

The readconsolering capabilities provide the opportunity to
provide console output to other clients (remote systems,
logging systems, etc). This patchs adds the ability to generate
a notification of a change in the console buffer.

Signed-off-by: Ben Thomas <ben@xxxxxxxxxxxxxxx>
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

> +             { "log", 1, 0, 'l' },
> +             { "log-dir", 1, 0, 'r' },

That 'r' option is not the most intuitively named...  What's wrong with
'd'?

> @@ -99,6 +137,18 @@ int main(int argc, char **argv)
>       handle_io();
>  
>       closelog();
> +     free(log_dir);
> +     free(pidfile);

Are you paid by the line? ;-)

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel