[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/12] Pull necessary Linux PM files


  • To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 11 Jun 2007 16:08:38 +0100
  • Delivery-date: Mon, 11 Jun 2007 08:06:45 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceW+39jOmNeDI8hQbKl0g0vvKGGDAVPuQRM
  • Thread-topic: [Xen-devel] [PATCH 2/12] Pull necessary Linux PM files

Could we not share some of this low-level code across 32 and 64 bits? A good
deal of it must be real mode asm anyway. Also it's weird that only x86/64
gets a new header file.

Overall, I think we should pick the cleanest one (x86/32 or x86/64) as a
starting point and then bludgeon the code so that it works for the other
sub-architecture too. This might involve a new file in the subarch
directories, but only for code that actually really is specific to that
subarch.

Or are there more fundamental differences than it first appears?

Also, I applied two of your patches now, which you will find in the staging
tree (one in xen, one in linux). It would be useful if you would resync the
remainder.

 -- Keir

On 15/5/07 15:15, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Just borrow 5 files from Linux, for necessary cpu context
> save/restore and wakeup stub. Except them, all the ACPI
> related operations are still carried by dom0.
> 
> Signed-off-by Ke Yu <ke.yu@xxxxxxxxx>
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.