Re: [Xen-devel] [PATCH] Make Xen headers lint-clean

[John Levon <john.levon@xxxxxxx>]

On Fri, Jun 15, 2007 at 09:30:39AM +0100, Keir Fraser wrote:

> > Make ring.h and xs_wire.h lint clean. Add an unused attribute to xsd_errors 
> > if
> > using GCC, so we don't get duplicate arrays in every object including the
> > header.
> 
> Casting memset() to void is completely barking. Noone ever cares about the
> return value, or looks at it: is half the C code in the universe not lint
> clean therefore?

Correct. lint isn't able to differentiate between sensible code and not. Which
leaves us with either having one slightly silly piece of code here or
maintaining a permanent patch against the file. I don't think it's too ugly to
not apply.

> And xsd_errors[] already has the unused attribute; this patch does not add
> it as the changeset comment suggests.

My apologies, I didn't notice this from forward-porting the patch.

> Do you require to use that header file with a compiler other than gcc?

Yes, all the public headers need to be compiled with Sun CC as well.
Unfortunately 'unused' is one of the GCC attributes they haven't implemented
yet.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel