Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 15/6/07 11:46, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:

> This is a repost of some earlier patches to the xen-devel mailing list,
> with a number of changes thanks to some useful suggestions from others.

The coding style needs fixing in various ways.

Hard tabs need to be used, no spaces inside brackets, but should include
spaces between if/while/for and bracket, and bracket and brace:
    if (foo) {
Not
    if( foo ){
    if(foo ) {
Or various other possibilities.

No use of the following please:
If (foo) return 1; else return 0;
Is clearer as:
Return foo;

There's a (good) idiom for error handling in Linux:
If (!error) {
    page of code;
} else {
    oh no, error, print and return;
}
Should be changed to:
If (error) {
    handle error, bail if necessary
}
Page of code, no longer indented by error check;

Apart from the various coding style bits, accelerator_probe_vifs_on_load()
walks the vif_states list with no lock held. Is this safe against the list
changing?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel