Re: [Xen-devel] [PATCH] x86: eliminate x86_emulate's private EFLAGS definitions

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 19.06.07 12:05 >>>
>On 19/6/07 10:54, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> .. in favor of using one of the two (i.e. already redundant) ones
>> found in the headers.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
>Currently x86_emulate is buildable 'out of tree', e.g., in tools/tests. I
>want to keep that ability but it is the case that down the line we'll be
>wanting more flags and structures to be sharable outside x86_emulate.c. I'm
>not sure yet what the right way of achieving that will be.

Yes, I was afraid of something like that (I just didn't know that I might be 
able
to build the thing in tools/tests, I thought this was completely out of tree, 
and
hence adding a local header would be possible).

In that light, perhaps doing a little cleanup on the headers having the desired
definitions, so that they can be included for the tool build, will do. I may 
find
some time to look into this possibility.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel