Re: [Xen-devel] [PATCH] Fix change of CDROM for block-configure command

["Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>]

Hi Keir,

Thank you for reply.

> ioemu-nowait-change: This 5s timeout is deliberate.
We consented that waiting was necessary for the Windows guest.

> ioemu-nocheck-change: The strcmp is deliberate, to filter out redundant
> firings of the xenstore watch. If you want to be able to e.g., ...
We corrected the patch like writing an empty once character in xend.

Signed-off-by: Takanori Kasai <kasai.takanori@xxxxxxxxxxxxxx>


BTW, there is an acute problem in the change of CDROM.

When physical device (/dev/cdrom) of CDROM is set first, 
CDROM of the second piece cannot be correctly read. 

It remains opening former device on backend 
even if it changes with block-configure.
Therefore, CDROM of the second piece can read only the size of the first piece.

linux-2.6.18-xen.hg/drivers/xen/blkback/xenbus.c
264  static void backend_changed(struct xenbus_watch *watch,
265                              const char **vec, unsigned int len)
...
315                  err = vbd_create(be->blkif, handle, major, minor,
316                                   (NULL == strchr(be->mode, 'w')));

How do you think that we should correct about this problem?

Best Regards,

--
Takanori Kasai

Attachment: python-blkif-change-cdrom.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel