[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [patch] crashkernel allocation failure #1


  • To: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
  • Date: Fri, 22 Jun 2007 11:39:02 +0200
  • Delivery-date: Mon, 25 Jun 2007 09:32:37 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

  Hi,

The kexec crash kernel area allocation code does some effort to move the images (i.e. kernel+initrd) out of the way, so the crashkernel area can be allocated at the default location (@16m).

In case initial_images_end is not page aligned a single page in the middle of the crash kernel area is leaked though, making the whole move effort fail.

The attached patch fixed that by rounding up initial_images_end to the next page boundary.

please apply,
  Gerd
--- xen/arch/x86/setup.c.fix    2007-05-03 09:40:19.000000000 +0200
+++ xen/arch/x86/setup.c        2007-06-19 11:19:11.000000000 +0200
@@ -453,6 +453,7 @@
     if ( initial_images_start < xenheap_phys_end )
         initial_images_start = xenheap_phys_end;
     initial_images_end = initial_images_start + modules_length;
+    initial_images_end = (initial_images_end + PAGE_SIZE - 1) & PAGE_MASK;
 
     move_memory(initial_images_start, 
                 mod[0].mod_start, mod[mbi->mods_count-1].mod_end);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.