Re: [Xen-devel] [PATCH 2/4] [Net] Support accelerated network pluginmodules

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Kieran,

I have a request and a question. 

Request:
 I think that we need to fix the help message of xm create command 
 for the accel option, so I wrote a patch for it.  I attach the 
 patch.  Could you comment on the patch?

Question:
 I ask you a question without understanding your patch enough. 
 Why did not you add the accel option to xm network-attach command? 


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan


>Add accel option to vif xend config
>
>Signed-off-by: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
>
>diff -r 405eb3e22887 tools/python/xen/xend/server/netif.py
>--- a/tools/python/xen/xend/server/netif.py    Thu Jun 14 14:50:04 2007 +0100
>+++ b/tools/python/xen/xend/server/netif.py    Thu Jun 14 14:52:55 2007 +0100
>@@ -107,6 +107,7 @@ class NetifController(DevController):
>         uuid    = config.get('uuid')
>         ipaddr  = config.get('ip')
>         model   = config.get('model')
>+        accel   = config.get('accel')
> 
>         if not typ:
>             typ = xoptions.netback_type
>@@ -131,6 +132,8 @@ class NetifController(DevController):
>             back['uuid'] = uuid
>         if model:
>             back['model'] = model
>+        if accel:
>+            back['accel'] = accel
> 
>         config_path = "device/%s/%d/" % (self.deviceClass, devid)
>         for x in back:
>@@ -157,10 +160,10 @@ class NetifController(DevController):
>         config_path = "device/%s/%d/" % (self.deviceClass, devid)
>         devinfo = ()
>         for x in ( 'script', 'ip', 'bridge', 'mac',
>-                   'type', 'vifname', 'rate', 'uuid', 'model' ):
>+                   'type', 'vifname', 'rate', 'uuid', 'model', 'accel'):
>             y = self.vm._readVm(config_path + x)
>             devinfo += (y,)
>-        (script, ip, bridge, mac, typ, vifname, rate, uuid, model) = devinfo
>+        (script, ip, bridge, mac, typ, vifname, rate, uuid, model, accel) 
>= devinfo
> 
>         if script:
>             result['script'] = script
>@@ -180,5 +183,7 @@ class NetifController(DevController):
>             result['uuid'] = uuid
>         if model:
>             result['model'] = model
>+        if accel:
>+            result['accel'] = accel
>             
>         return result
>diff -r 405eb3e22887 tools/python/xen/xm/create.py
>--- a/tools/python/xen/xm/create.py    Thu Jun 14 14:50:04 2007 +0100
>+++ b/tools/python/xen/xm/create.py    Thu Jun 14 14:52:55 2007 +0100
>@@ -710,7 +710,7 @@ def configure_vifs(config_devs, vals):
> 
>         def f(k):
>             if k not in ['backend', 'bridge', 'ip', 'mac', 'script', 'type',
>-                         'vifname', 'rate', 'model']:
>+                         'vifname', 'rate', 'model', 'accel']:
>                 err('Invalid vif option: ' + k)
> 
>             config_vif.append([k, d[k]])
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel

Attachment: help_create_vif.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel