Re: [Xen-devel] [PATCH 4/4] [XEND] add scsihost interface

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Tomonari,

I have two comments. 

XendDevices.py:
@@ -36,6 +36,7 @@ class XendDevices:
 
     controllers = {
         'vbd': blkif.BlkifController,
+       'scsihost': scsihostif.SCSIHostController,
         'vif': netif.NetifController,
         'vtpm': tpmif.TPMifController,
         'pci': pciif.PciController,

The added line includes a tab.


main.py:
@@ -2213,6 +2262,10 @@ def xm_block_detach(args):
         except:
             pass
         detach(args, 'tap')
+
+def xm_scsihost_detach(args):
+    arg_check(args, "xm_scsihost_detach", 2, 3)
+    detach(args, 'scsihost-detach', 'scsihost')
 
 def xm_network_detach(args):
     if serverType == SERVER_XEN_API:

The number of argument of detach() is two. 
'scsihost-detach' is unnecessary. 


Best regards,
 Kan

>
>[PATCH 4/4] [XEND] add scsihost interface
>
>
>Best regards,
>Tomonari Horikoshi
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel