Re: [Xen-devel] [PATCH] Allow blktap to be able to be booted as system volume for PV-on-HVM(TAKE 2)

["Takekazu Okamoto" <tokamoto@xxxxxxxxxx>]

Kasai-san,

It seems your code works only for hda. (hd_index == 0)
+            /* Strip off blktap sub-type prefix aio: etc for hda */
+            if (hd_index == 0) {
+                char *p = NULL;
+                if((p = strchr(params, ':'))) {
+                    memmove(params, p+1, strlen(p+1)+1); 
+                    fprintf(stderr, "Strip off blktap sub-type prefix
aio: etc ");
+                    fprintf(stderr, "for hda\n   : params='%s'\n",
params);
+                }
+            }

Daniel's and my code do not care the index.
Quote from Daniel's code:
+       /* Strip off blktap sub-type prefix aio: - QEMU can autodetect
this */
+       if (!strcmp(drv, "tap") && params[0]) {
+           char *offset = strchr(params, ':');
+           if (!offset)
+               continue;
+           fprintf(logfile, "Stripping blktap sub-type prefix from
%s\n", params);
+           memmove(params, offset+1, strlen(offset+1)+1);
+       }
+       fprintf(logfile, "Creating disk '%s' with driver '%s'\n", dev,
drv);

Regards,
Takekazu Okamoto
Novell Japan

>>> "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx> 2007/07/20 12:55
>>>
Okamoto-san,

Thank you for reply.

> But I think it's better to work with all disks regardless of PV
> drivers.
> Because some users would like to run OSs without PV drivers.

I think that it only has to use hd* because it is a usual HVM domain
without PV 
drivers.
Should you specify xvd* so that only the emulator may use it?

Best Regards,

--
Takanori Kasai

----- Original Message ----- 
From: "Takekazu Okamoto" <tokamoto@xxxxxxxxxx>
To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Sent: Friday, July 20, 2007 1:45 AM
Subject: Re: [Xen-devel] [PATCH] Allow blktap to be able to be bootedas
system 
volume for PV-on-HVM(TAKE 2)


> Kasai-san,
>
> I understand why you did.
> But I think it's better to work with all disks regardless of PV
> drivers.
> Because some users would like to run OSs without PV drivers.
> There are also benefits for such users with "tap:vmdk:", "tap:qcow:"
or
> "tap:sync:", I think.
>
> Regards,
> Takekazu Okamoto
> Novell Japan
>
>>>> "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx> 2007/07/19 15:49
>>>>
> Hi Okamoto-san,
>
> Thank you for reply.
>
>> Why did you make a patch only for boot disk?
>
> Because it is not necessary to start with the emulator excluding the
> system
> disk.
>
> The system disk cannot be booted if it doesn't work by the emulator
> first.
> But the data disk will work as blktap if PV driver works after
> booting.
>
>
> There is a reason why all xvd* is not replaced with hd* either.
>
> We are working the system disk as hda and CDROM device as hdc.
> Moreover, we are working the data disk as xvd *.
>
> disk  = [ 'tap:aio:/image/systemdisk.img,hda,w',
>              'phy:/dev/cdrom,hdc:cdrom,r',
>              'tap:aio:/image/data1.img,xvda,w',
>              'tap:aio:/image/data2.img,xvdb,w',
>              'tap:aio:/image/data3.img,xvdc,w',
>              'tap:aio:/image/data4.img,xvdd,w',
>               ....   ]
>
> Therefore, when xvd * is replaced to hd*,
> hd* usually used by the HVM domain cannot be used.
>
> Best Regards,
>
> --
> Takanori Kasai
>
> ----- Original Message ----- 
> From: "Takekazu Okamoto" <tokamoto@xxxxxxxxxx>
> To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, July 19, 2007 2:46 PM
> Subject: Re: [Xen-devel] [PATCH] Allow blktap to be able to be
> bootedassystemvolume for PV-on-HVM(TAKE 2)
>
>
>> Kasai-san,
>>
>> Why did you make a patch only for boot disk?
>> I have a patch for all disks on SLES10SP1 (3.0.4). (Not yet in
>> SLES10SP1 tree)
>> Windows can boot up in HVM domain with our PV drivers for blktap
>> disks.
>> For your reference, it is attached in this mail.
>> I know this is for 3.0.4, not applicable for latest.
>>
>> Regards,
>> Takekazu Okamoto
>> Novell Japan
>>
>>>>> "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx> 2007/07/19
13:41
>>>>>
>> Hi All,
>>
>> I sent the patch to make blktap work with PV-on-HVM.
>> For system volume to boot hda or xvda, I corrected the patch.
>> However, the patch has not been applied yet.
>> Could you apply this patch? Or, please give the comment to me.
>>
>> Best Regards,
>>
>> ---
>> Takanori Kasai
>>
>>
>> ----- Original Message ----- 
>> From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
>> To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
>> Sent: Thursday, July 12, 2007 9:13 AM
>> Subject: [Xen-devel] [PATCH] Allow blktap to be able to be booted
as
>> systemvolume for PV-on-HVM(TAKE 2)
>>
>>
>>> Hi All,
>>>
>>> I sent the patch to make blktap work with PV-on-HVM.
>>> For system volume to boot hda or xvda,
>>> I corrected the patch.
>>>
>>> Signed-off-by: Takanori Kasai <kasai.takanori@xxxxxxxxxxxxxx>
>>>
>>> This patch made it possible to use either.
>>>
>>> disk = [ 'tap:aio:/xen/test/rhel5ga_full.img,hda,w' ]
>>> or
>>> disk = [ 'tap:aio:/xen/test/rhel5ga_full.img,xvda,w' ]
>>>
>>> It is assumed that hda is a volume of the system
>>> if both xvda and hda are specified.
>>>
>>> disk = [ 'file:/xen/test/rhel5ga_full.img,hda,w',
>>>         'tap:aio:/xen/test/drive2.img,xvda,w' ]
>>>
>>> Best Regards,
>>>
>>> --
>>> Takanori Kasai
>>>
>>>
>>> ----- Original Message ----- 
>>> From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
>>> To: "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
>>> Sent: Friday, July 06, 2007 7:50 PM
>>> Subject: [Xen-devel] [PATCH] Allow blktap to be able to be booted
> as
>>> systemvolume for PV-on-HVM
>>>
>>>
>>>> Hi All,
>>>>
>>>> We were testing the PV driver on the HVM domain.
>>>> When blktap was booting system volume, PV-on-HVM domain was not
> able
>> to be
>>>> started.
>>>>
>>>> The configuration file is specified as follows.
>>>> disk = [ 'tap:aio:/xen/test/rhel5ga_full.img,hda,w' ]
>>>>
>>>> The error occurred by the initialization of system volume in
>> qemu-dm.
>>>>
>>>> qemu: could not open hard disk image
>> 'aio:/xen/test/rhel5ga_full.img'
>>>>
>>>> It is because "aio:" is added to the head of params in xenstore.
>>>> However, qemu-dm open device by params.
>>>>
>>>> This patch corrected the problem of params on the qemu-dm.
>>>>
>>>> Signed-off-by: Takanori Kasai <kasai.takanori@xxxxxxxxxxxxxx>
>>>> Signed-off-by: Tomonari Horikoshi <t.horikoshi@xxxxxxxxxxxxxx>
>>>> Signed-off-by: Tsunehisa Doi <Doi.Tsunehisa@xxxxxxxxxxxxxx>
>>>>
>>>> The execution result is as follows.
>>>>
>>>> # xm create -f rhel5ga_vti.conf
>>>> Using config file "./rhel5ga_vti.conf".
>>>> Started domain RHEL5GA-test2
>>>> # xm block-list RHEL5GA-test2
>>>> Vdev  BE handle state evt-ch ring-ref BE-path
>>>> 768    0    0     1      -1     -1
>> /local/domain/0/backend/tap/75/768
>>>> ...      <<= /* Waiting for booting process */
>>>> # xm block-list RHEL5GA-test2
>>>> Vdev  BE handle state evt-ch ring-ref BE-path
>>>> 768    0    0     4      7      8
>> /local/domain/0/backend/tap/75/768
>>>>
>>>> Best Regards,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel