Re: [Xen-devel] [PATCH] Correct public header defines for Solaris/Sun CC

[John Levon <john.levon@xxxxxxx>]

On Thu, Aug 09, 2007 at 10:08:24AM +0100, Keir Fraser wrote:

> On 8/8/07 19:04, "john.levon@xxxxxxx" <john.levon@xxxxxxx> wrote:
> 
> > Correct public header defines for Solaris/Sun CC
> > 
> > The Solaris environment only defines __i386, not __i386__.
> > Additionally, the assembler define used is _ASM. Accommodate both.
> 
> Can't you just include xen.h through a wrapper that makes these definitions
> for your non-gnu environment? Since I assume this is for Solaris and so you
> have full control over the source code of the includer.

Well that's what we're doing now. But there are two disadvantages here:

1) we have to maintain these changes indefinitely and make sure everything goes
through this wrapper. Extra-upstream changes suck and we do our best to avoid
them wherever we can.

2) the wrapper only applies to the kernel, whereas these headers are used in
userspace too. Whilst there's no immediate intention of compiling the Xen
sources themselves with Sun CC, it seems unnecessarily sharp to prevent any
tools from using these headers directly in such an environment

And finally, it's not a large or particularly ugly change...

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel