[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH][QEMU] Make active-timers thread-safe



After speaking with the original developer of this patch, it may have been a mistake to port it forward from the 3.1 codebase.

This submission was premature.
We will do some investigation to see if this is still a problem in unstable.

Apologies,
Ben

Daniel P. Berrange wrote:
On Mon, Aug 27, 2007 at 02:58:26PM -0400, Ben Guthro wrote:
Protect active_timers[] lists with mutexes so timers can be safely used from different threads.

What code in QEMU is actually still using threads ? There used to be a Xen
specific patch to the IDE layer to perform DMA ops in threads, but that was
removed when xen-unstable synced with QEMU 0.9.0. Not aware of anything
else using threads in the QEMU device model - its pretty dangerous because
QEMU's internal data structures basically all assume single-threaded access.

Regards,
Dan.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.