[Xen-devel] Re: Xenstored: eliminate double free and fixes for memory leak

["Peter Teoh" <htmldeveloper@xxxxxxxxx>]

The changes are too interdependent, and therefore, I am now
resubmitting it as a complete patch, instead of splitting it up into
multiple patches.   All goes to the same file - xenstored_core.c.

On top of the comments given above, here are the additional comments:

Two FIXME comments added - for which a problem has been identified,
but fixing it will incurred a lot of changes in design etc.

First problem is the returned value from get_parent() - it can be
either a static value, or a dynamically allocated value (from
talloc_asprintf()), and therefore it is very difficult to judge
whether to free the memory or not.

Second (minor) problem is during destroy_node(), the allocated memory
within the node structure is not free.   These are allocated in
construct_node() function.

Please comments, thanks.

Attachment: eliminate_double_free_and_mem_leak.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel