Re: [Xen-devel] [PATCH] libfsimage: Make it build on NetBSD

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 21/9/07 13:39, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Attached patch makes libfsimage build on NetBSD
> by fixing a number of those errors:
> 
> cc1: warnings being treated as errors
> fsys_fat.c: In function 'fat_dir':
> fsys_fat.c:304: warning: array subscript has type 'char'

You also cast before a comparison with a char literal ('/'). Surely that
isn't necessary?

For the rest, it does sound like NetBSD's ctype.h is strictly compliant with
ISO C, which requires a non-EOF argument to be representable as an unsigned
char. Clearly a negative argument is not representable as an unsigned char
of the same integer value, so a cast is needed to force things to comply
with the ISO spec. Bah.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel