Re: [Xen-devel] [PATCH] Default serial console to BAUD_AUTO

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 24/9/07 20:40, "John Levon" <john.levon@xxxxxxx> wrote:

>> and, really, you can just put 'com1=auto' on your command
>> line to get the same effect and then noone gets surprised by Xen locking
>> down serial ports when com1/com2 does not appear on their Xen command line.
> 
> Fair enough, we should not use the serial console by default (although at
> least
> Solaris will feed output through HYPERVISOR_console_io if Xen's already
> grabbed
> it). However, I don't think that the current *code* (whereby the serial
> console
> gets disabled as a side effect of not setting BAUD_AUTO, and OPT_CONSOLE_STR
> does not do what it appears to do) is readable or maintainable. Can we please
> make the intention of the code clear?
> 
> Neither do I think that forcing users to unnecessarily set "com1=auto" is good
> UI.

I can cook up something appropriate I think.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel