[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [VTD][PATCH] Don't allow assigning the same device twice without release the first assignment


  • To: "Han, Weidong" <weidong.han@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 16 Oct 2007 07:41:16 +0100
  • Cc: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
  • Delivery-date: Mon, 15 Oct 2007 23:36:50 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcgPPrZDfEJfzCOtSJyuGbCE3/cnAQAAjKktABVSMsAAClbYKw==
  • Thread-topic: [Xen-devel] [VTD][PATCH] Don't allow assigning the same device twice without release the first assignment

On 16/10/07 03:04, "Han, Weidong" <weidong.han@xxxxxxxxx> wrote:

>> The DOMCTL_assign_device should check whether the device is already
>> assigned. This has the benefit that it can atomically
>> check-and-allocate, under the domctl lock.
>> 
>> You'll have to work out how to propagate DOMCTL_assign_device failure
>> to the user. Either you have to get the error out of ioemu, or
>> perhaps you can assign the device in xend before starting ioemu.
> 
> Yes, adding the check on DOMCTL_assign_device is simple, but I didn't
> find a good way to propagate DOMCTL_assign_device failure to user. This
> patch adds the check in xend before starting ioemu. In addtion, adding
> the check in Xend can prompt user on the screen when the device has
> already been assigned. Thanks.

Well, that's too bad because I won't take the original patch. Why can't the
device be assigned by xend?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.