[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 0/5] Add MSI support to xen environment


  • To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 26 Oct 2007 10:13:30 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 26 Oct 2007 02:14:30 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcgXJpgKtuetZtZRSk2SPUOVajTGGQAieFwC
  • Thread-topic: [PATCH 0/5] Add MSI support to xen environment

The PHYSDEVOP_map_irq concept is a bit broken. Firstly the new op is not
protected from domU usage. Secondly it looks like the current code will
break with old dom0 kernels that do not use PHYSDEVOP_map_irq. That's not
allowed.

I think it'd be better for pciback to poke the irq configuration into
xenstore, and then that can be picked up by the domain builder before
starting the domain. Then xend can be responsible for actually setting up
the mapping to a pirq, and all these new hypercalls can be domctls. The
advantage of this is that they're not then set in stone. I'm not confident
about overhauling the irq interface and declaring it fully baked just before
a tree freeze.

 -- Keir

On 25/10/07 17:46, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:

> Hi, 
> The followed series patches add MSI support to xen environment. Please
> have a look on it and give me any suggestion and I'd like to update
> accordingly.
> 
> The basic idea including:
> 1) Keep vector global resource owned by xen, while split pirq into per
> domain information.
> 2) domain0 kernel will operate msi resource for domain0/domU, while QEMU
> will operate MSI resource for HVM domain.
> 3) Xen will do EOI for MSI interrupt.
> 
> pirq_per_domain.patch is mainly changes to xen source tree for
> per-domain pirq.
> domain_pirq_kernel.patch is changes to linux tree for per-domain pirq.
> 
> msi_irq_xen.patch changes xen to support msi for domain0/domainU.
> msi_kernel.patch changes linux tree to support msi.
> 
> msi_passthrough.patch add msi support to passthrough hvm domain.
> 
> Signed-off-by: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>
> 
> Thanks
> Yunhong Jiang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.