[Xen-devel] [Patch 0/8] Netfront accelerator bug fixes

[Kieran Mansley <kmansley@xxxxxxxxxxxxxx>]

This patch set fixes a number of bugs in the netfront accelerator
architecture that have been brought to light by a recent bout of code
review and testing.  The majority are minor and self explanatory, but
two involve a fair bit of code churn and deserve more explanation.

The first big one (2/8) involves a change to the API for the
accelerators around suspend/resume.   Previously netfront would just
pass the xenbus suspend/resume callbacks through to the appropriate
accelerator and it would deal with it from there.  The bug was that the
only sensible action for the accelerator was to unplug itself from
netfront, but this was a "per-module" operation rather than a "per-
interface" operation like suspend.  The fix removes the suspend and
resume hooks and instead netfront calls the accelerator's remove and
probe hooks on each interface when they are suspended/resumed.

The second big one (7/8) simplifies the locking used in the netfront
accelerator.  We found a couple of theoretical bugs in the old system
and to cut a long story short the best solution seemed to be to simplify
it somewhat.  A mutex is now used to prevent concurrent load/unload type
operations, and as the remaining hooks into the accelerator could
neither block nor recurse the kref that was being used was no longer
required.

I appreciate that these are a day late for 3.2.0 but as bug fixes that
represent a genuine improvement I'd hope they could be included.

Signed-off-by <kmansley@xxxxxxxxxxxxxx>

Thanks

Kieran


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel