Re: [Xen-devel] [VTD][PATCH] Support intra-domain shared interrupt

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

The two cases of hvm_dpci_eoi() (timeout versus non-timeout) have very
little code in common. Should be two different functions instead of adding a
cryptic final bool argument.

xmalloc() and list_add() should usually be accompanied with a destructing
list_del() and xfree(). So this patch leaks memory.

And why is intra-domain sharing harder (or at least different) to deal with
than inter-domain? Is this real physical IRQ sharing that's a problem, or
sharing of the virtual GSI?

 -- Keir

On 5/11/07 05:35, "Han, Weidong" <weidong.han@xxxxxxxxx> wrote:

> Inter-domain shared interrupt has been supported by timeout method, but
> it still doesn't support intra-domain shared interrupt, that is
> assigning multiple devices which share a physical irq to the same
> domain. This patch implements intra-domain shared interrupt support. In
> addition, this patch maps link to guest device/intx instead of directly
> mapping isairq in pt_irq_create_bind_vtd(), because at this point the
> isairqs got from pci_link are always 0.
> 
> Note that assigning multiple devices to guests which uses PIC to handle
> interrupts may be failed, because different links possibly connect to
> same irq.
> 
> 
> Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel