[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH]: Really disable pirq's

  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Chris Lalancette <clalance@xxxxxxxxxx>
  • Date: Wed, 14 Nov 2007 14:10:56 -0500
  • Delivery-date: Wed, 14 Nov 2007 11:11:33 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

     I have a laptop here that has some interrupt trouble, unrelated to Xen (I
believe it's a bug in the ACPI tables, but I digress).  On the bare-metal
kernel, if 999,900 out of 100,000 interrupts go un-acknowledged to a particular
interrupt line, the kernel disables that interrupt line.  In the Xen kernel, the
same logic applies.  However, when the Xen kernel goes to disable the physical
interrupt, it only masks out the event channel:

static void disable_pirq(unsigned int irq)
        int evtchn = evtchn_from_irq(irq);

        if (VALID_EVTCHN(evtchn))

And at this point, *all* interrupts on the affected machine seem to stop, not
just this physical IRQ line.  I believe the problem is that when we go to
disable a PIRQ, we actually need to get the HV to mask it out on the IOAPIC.
This patch does exactly that; on disable_pirq(), we actually just call out to
shutdown_pirq(), which ends up hypercalling and getting the HV to mask out the
interrupt.  On the other side, I needed to modify enable_pirq() to call out to
startup_pirq(), so that it would actually allocate the event channel.

With this patch in place, the affected laptop no longer hangs up when the kernel
decides to disable that particular interrupt line.

Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>
--- linux-2.6.18.noarch/drivers/xen/core/evtchn.c.orig
+++ linux-2.6.18.noarch/drivers/xen/core/evtchn.c
@@ -629,20 +629,12 @@ static void shutdown_pirq(unsigned int i
 static void enable_pirq(unsigned int irq)
-       int evtchn = evtchn_from_irq(irq);
-       if (VALID_EVTCHN(evtchn)) {
-               unmask_evtchn(evtchn);
-               pirq_unmask_notify(irq_to_pirq(irq));
-       }
+       startup_pirq(irq);
 static void disable_pirq(unsigned int irq)
-       int evtchn = evtchn_from_irq(irq);
-       if (VALID_EVTCHN(evtchn))
-               mask_evtchn(evtchn);
+       shutdown_pirq(irq);
 static void ack_pirq(unsigned int irq)
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.