Re: [Xen-devel] [Mini-OS] Drop useless -fpic flag

[Grzegorz MiÅoÅ <gm281@xxxxxxxxx>]

Yes, that's right. At the time I was writing the first version I just  
copied all the flags. I, too, believe -fpic acn be discarded.
Cheers
Gregor

On 28 Nov 2007, at 16:42, Keir Fraser wrote:

> Ah yes, I think the -fpic was inherited from Xen's Makefile. Xen has  
> to be
> built -fpic because it is not linked sufficiently close to address  
> 0x0 to
> use absolute addressing the 32-bit displacements. This isn't the  
> case for
> minios.
>
> -- Keir
>
> On 28/11/07 16:35, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx>  
> wrote:
> > Keir Fraser, le Tue 27 Nov 2007 12:33:23 +0000, a écrit :
> > > If it builds without it then it should be fine, I believe.
> > And nobody raised his hand, so here is a patch:
> >
> > Drop useless -fpic flag.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxx>
> >
> > diff -r c555a5f97982 extras/mini-os/arch/x86/arch.mk
> > --- a/extras/mini-os/arch/x86/arch.mk Wed Nov 28 13:36:56 2007 +0000
> > +++ b/extras/mini-os/arch/x86/arch.mk Wed Nov 28 16:33:37 2007 +0000
> > @@ -17,7 +17,7 @@ endif
> > endif
> >
> > ifeq ($(TARGET_ARCH),x86_64)
> > -ARCH_CFLAGS := -m64 -mno-red-zone -fpic -fno-reorder-blocks
> > +ARCH_CFLAGS := -m64 -mno-red-zone -fno-reorder-blocks
> > ARCH_CFLAGS += -fno-asynchronous-unwind-tables
> > ARCH_ASFLAGS := -m64
> > ARCH_LDFLAGS := -m elf_x86_64
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel