[Xen-ia64-devel] Re: [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 28/11/07 18:39, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    You're right, thanks for bringing it to my attention that storing it
> in an hvm_param is simply unnecessary.  If we add the guest_os_type
> config option as per the new patch below, and still add the
> XEN_DOMCTL_set_opt_feature call, everything else can be done in
> architecture code.  I'll make a pyxc binding to an xc_ia64_set_os_type
> that gets passed self.guest_os_type and makes use of set_opt_feature.
> This avoids munging the string into an integer entirely and keeps
> guest_os_type out of Xen.  Does this look more reasonable?  Please also
> apply this and the original XEN_DOMCTL_set_opt_feature patch if so.

Yes, this sounds fine to me.

 -- Keir



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel