Re: [Xense-devel] [PATCH] update for Trusted Boot v20071128

[Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>]

Hi, 

I have just one question.
Currently Your patch supports version=0x01 only?
>From seeing tboot code, It seems 
0x01 for tboot-20071029
0x02 for tboot-20071128
I think it should fix the comment of "version" in tboot_shared_t.

Thanks
Atsushi SAKAI


"Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote:
>  typedef struct __attribute__ ((__packed__)) {
> +    /* version 0x01+ fields: */
>      uuid_t    uuid;              /*
> {663C8DFF-E8B3-4b82-AABF-19EA4D057A08} */
>      uint32_t  version;           /* 0x01 */
>      uint32_t  log_addr;          /* physical addr of tb_log_t log */
> @@ -59,6 +60,9 @@ typedef struct __attribute__ ((__packed_
>      uint32_t  s3_k_wakeup_entry; /* entry point for xen s3 wake up */
>      uint8_t   acpi_sinfo[MAX_TB_ACPI_SINFO_SIZE];
>                                   /* where kernel put acpi sleep info in
> Sx */
> +    /* version 0x02+ fields: */
> +    uint32_t  tboot_base;        /* starting addr for tboot */
> +    uint32_t  tboot_size;        /* size of tboot */
>  } tboot_shared_t;
>  
>  #define TB_SHUTDOWN_REBOOT      0



_______________________________________________
Xense-devel mailing list
Xense-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xense-devel