[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH][cpufreq] add bounds checking for getcpuidletime
The Xen platform hypercall for getting the cpu idletime does not check to make sure that all cpus in the map have indexes less than the size of the array that it writes the data into. Add bounds checking to avoid memory corruption. Signed-off-by: Mark Langsdorf <mark.langsdorf@xxxxxxx> diff -r d40788f07a4f xen/arch/x86/platform_hypercall.c --- a/xen/arch/x86/platform_hypercall.c Sun Nov 25 12:43:13 2007 +0000 +++ b/xen/arch/x86/platform_hypercall.c Mon Dec 03 10:25:23 2007 -0600 @@ -326,6 +326,9 @@ ret_t do_platform_op(XEN_GUEST_HANDLE(xe cpu_clear(cpu, cpumap); } + if (cpu >= ctlmap.nr_cpus) + continue; + ret = -EFAULT; if ( copy_to_guest_offset(idletimes, cpu, &idletime, 1) ) goto out; _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |