[Xen-devel] [PATCH] linux/i386: Use symbolic constants in dump_fault_path()

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

As usual, written and tested against 2.6.24-rc3 and made apply against
2.6.18 without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: head-2007-11-30/arch/i386/mm/fault-xen.c
===================================================================
--- head-2007-11-30.orig/arch/i386/mm/fault-xen.c       2007-12-06 
14:56:17.000000000 +0100
+++ head-2007-11-30/arch/i386/mm/fault-xen.c    2007-12-04 09:46:23.000000000 
+0100
@@ -231,7 +226,7 @@ static void dump_fault_path(unsigned lon
        p  = (unsigned long *)__va(page);
        p += (address >> 30) * 2;
        printk(KERN_ALERT "%08lx -> *pde = %08lx:%08lx\n", page, p[1], p[0]);
-       if (p[0] & 1) {
+       if (p[0] & _PAGE_PRESENT) {
                mfn  = (p[0] >> PAGE_SHIFT) | (p[1] << 20);
                page = mfn_to_pfn(mfn) << PAGE_SHIFT; 
                p  = (unsigned long *)__va(page);
@@ -244,7 +239,7 @@ static void dump_fault_path(unsigned lon
                if (mfn_to_pfn(mfn) >= highstart_pfn)
                        return;
 #endif
-               if (p[0] & 1) {
+               if (p[0] & _PAGE_PRESENT) {
                        page = mfn_to_pfn(mfn) << PAGE_SHIFT; 
                        p  = (unsigned long *) __va(page);
                        address &= 0x001fffff;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel