Re: [Xen-devel] [PATCH][TOOLS] blktap: factor out linux specific code

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 6/12/07 19:00, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> On Thu, Dec 06, 2007 at 07:52:32PM +0100, Christoph Egger wrote:
> 
>> -  s->fd_end = lseek64(fd, 0, SEEK_END);
>> -  if (s->fd_end == (off64_t)-1)
>> +  s->fd_end = lseek(fd, 0, SEEK_END);
>> +  if (s->fd_end == (off_t)-1)
> 
> Why this change? Seems that it will break for any large file?

Nope, we turn on implicit 64-bit-safe file operations by throwing LFS
goodness into CFLAGS and LDFLAGS in tools/Rules.mk. There's no need to use
the explicit *64 function and typedef names.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel