Re: [Xen-devel] [PATCH] fix gdb debugging of hypervisor

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 11/12/07 17:41, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> The best way to deal with this seemed to me to make
> __spurious_page_fault always return false when the debugger is
> attached (ie, when we are running the debugging stub).  The comments
> surrounding __spurious_page_fault seem to suggest that these only
> occur when page tables are changed.  If that's true then this change
> is correct since the debugging stubs don't change page tables.

I think it's more obvious to check for in_irq(). That predicate already
exists, and pagetables are never updated in IRQ context. And it's exactly
the case that __spurious_page_fault() cannot handle. Apart from that the
patch is good.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel