[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 0/5] [ioemu]: fix ioemu warnings


the following patches fix the warnings which appear when compiling ioemu on gcc4 (tested with gcc 4.1.2). As gcc4 is uncommon for pure QEMU, this hasn't been fixed there for a while. Keir stated that QEMU-related fixes should be upstream there, so I sent an adapted version of these patches to qemu-devel in December[1]. Eventually they got accepted there[2], so here is a ported version for ioemu.

I don't know if this is in vain, since a few days ago QEMU 0.9.1 has been released, which includes the patches (at least the QEMU-only-related). As I see from the commit-logs, ioemu gets updated to release versions of QEMU now and then, are there plans for doing this for 0.9.1?
And NO, I don't want to volunteer ;-)

The patches in detail:
1/5: fix wrong types:
gcc4 is more picky about the signedness of a pointer. Some variables were declared with an inappropriate signedness, this patch fixes this.
2/5: pointer casts:
Not all signedness pointer issues can be fixed by declaration, sometimes casts are necessary (mostly char* vs. uint8_t*).
3/5: qemu_{put,get} pointer signedness:
qemu_put* and qemu_get* use a unsigned pointer to the variables, some of them are declared signed, so this provokes a warning. Switching to call by value version of qemu_put, so the compiler handles this correctly.
4/5: fix declaration after statement:
ISO C90 forbids mixed declarations and code. ioemu is compiled with -Wdeclaration-after-statement, so this produces a warning. Moved the declerations to the beginning of a new block. This patch is not yet upstream in QEMU.
5/5: miscellaneous:
Some minor things (details in the patch)


[1]: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00146.html
[2]: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00417.html

Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.