Re: [Xen-devel] [PATCH] respin of mprotect performance patch

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13/1/08 03:08, "Bruce Rogers" <brogers@xxxxxxxxxx> wrote:

> I made a few tweaks to your patch as follows:
> As I see it we need to preserve the existing AD bits but additionally OR in
> the AD bits being passed in (see behavior of pte_modify(), where it preserves
> current AD in use of _PAGE_CHG_MASK along with ORing in newprot bits, which
> include AD bits (A at least).)
> See update_intpte() for this change.

This way is strictly more expressive (you can get my behaviour by clearing
A/D bits in the passed-in 'val'). So seems good to me.

> Also we need to remove cmd value from req.ptr in do_mmu_update..

Yes, missed that.

Looks good!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel