[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] -DNDEBUG for hypervisor only



IMO in general use of -DNDEBUG to disable assert() is not good
practice in userland code.

The attached patch applies this flag to the hypervisor only, by moving
the setting from Config.mk to Rules.mk.

Ian.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Index: xen-unstable.hg/Config.mk
===================================================================
--- xen-unstable.hg.orig/Config.mk      2008-01-15 16:27:36.000000000 +0000
+++ xen-unstable.hg/Config.mk   2008-01-15 16:28:06.000000000 +0000
@@ -57,9 +57,7 @@
     endif
 endef
 
-ifneq ($(debug),y)
-CFLAGS += -DNDEBUG
-else
+ifeq ($(debug),y)
 CFLAGS += -g
 endif
 
Index: xen-unstable.hg/xen/Rules.mk
===================================================================
--- xen-unstable.hg.orig/xen/Rules.mk   2008-01-15 16:27:33.000000000 +0000
+++ xen-unstable.hg/xen/Rules.mk        2008-01-15 16:28:08.000000000 +0000
@@ -17,6 +17,8 @@
 ifeq ($(debug),y)
 verbose       := y
 frame_pointer := y
+else
+CFLAGS += -DNDEBUG
 endif
 ifeq ($(perfc_arrays),y)
 perfc := y
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.