[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Wed, 16 Jan 2008 16:46:26 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 16 Jan 2008 08:46:54 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchYX1WFlBdyYMRSEdy6vwAX8io7RQ==
  • Thread-topic: [Xen-devel] linux: {start, stop}_hz_timer() not really affecting periodic timer?

On 16/1/08 16:36, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> If the time is in the past then the singleshot timer will fire immediately.
>> So you'll take a slower path than necessary, but the code as-is will work
>> fine.
> Immediately would mean to me that it would fire on the return path
> from VCPUOP_set_singleshot_timer, so HYPERVISOR_block() would
> not (necessarily) find any pending events and hence block when it
> shouldn't. Or am I missing some magic by which this is being avoided?

The function should only be called with interrupts disabled.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.