Re: [Xen-devel] [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-install

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 18/1/08 21:59, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

> I've not seen any problems on Xen 3.2 release with creating domains, but have
> not had any time to test the 3.1-testing tree since the 3.1.2 release came out
> so can't confirm that yet. I'll try and reproduce it - what error were you
> getting
> when trying to create a VM ?  libvirt doesn't specify any timer_mode parameter
> when creating VMs, so it should use whatever XenD's default is for that.

In Dan's patch, I don't know about the change to XendConfig.py, but the
change from ['platform'].get('timer_mode') to ['timer_mode'] doesn't look
very likely. All other HVM config parameters handed down from xm create end
up in the 'platform' dict.

Is the change to XendConfig.py to specify a default for timer_mode actually
ending up putting that default value in the wrong place: in the vmconfig as
a first-class entry in its own right, rather than as a sub-key of
'platform'?

If the problem is lack of a default value for timer_mode in some cases, I'd
rather fix XendDomainInfo.py to handle non-existent timer_mode key.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel