[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] about vga_endboot logic


  • To: 余上 <yusunn@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 21 Jan 2008 11:45:06 +0000
  • Delivery-date: Mon, 21 Jan 2008 03:45:33 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchcIxERT4l2CMgWEdyfNQAX8io7RQ==
  • Thread-topic: [Xen-devel] about vga_endboot logic

This is already correct in all active branches (3.1, 3.2, 3.3).

 -- Keir

On 19/1/08 15:30, "余上" <yusunn@xxxxxxxxx> wrote:

> Hi all ,
> 
> I think the logic of vga_endboot is not correct , if I pass vga=keep
> xen will print :
> Xen is keeping VGA console.
> but if I do not pass keep parmeter xen will not print :
> Xen is relinquishing VGA console.
> 
> The new logic should be:
> 
> void vga_endboot(void)
> {
>     if ( !vgacon_enabled )
>         return;
> 
>     printk("Xen is %s VGA console.\n",
>            vgacon_keep ? "keeping" : "relinquishing");
> 
>     if ( !vgacon_keep )
>         vgacon_enabled = 0;
> 
> }
> just move printk before the second if statement
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.