[Xen-devel] [PATCH] Remove device information when VmError occurred

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi,

I tested xm block-attach command with a wrong parameter(file:). 
Naturally a command error occurred. 
Then I retested xm block-attach command with a correct parameter(phy:). 
But a command error occurred again. 
The second command error occurred because Xend did not remove device 
information from self.info when the first command error occurred. 

# xm block-attach vm1 file:/dev/hda4 hdb1 w
Error: Device 833 (vbd) could not be connected. /dev/hda4 does not exist.
Usage: xm block-attach <Domain> <BackDev> <FrontDev> <Mode> [BackDomain]

Create a new virtual block device.
# xm block-attach vm1 phy:/dev/hda4 hdb1 w
Error: The file "/dev/hda4" is already used
Usage: xm block-attach <Domain> <BackDev> <FrontDev> <Mode> [BackDomain]

Create a new virtual block device.
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/1/769
#


This patch fixes the issue.  The test result is as follows. 

# xm block-attach vm1 file:/dev/hda4 hdb1 w
Error: Device 833 (vbd) could not be connected. /dev/hda4 does not exist.
Usage: xm block-attach <Domain> <BackDev> <FrontDev> <Mode> [BackDomain]

Create a new virtual block device.
# xm block-attach vm1 phy:/dev/hda4 hdb1 w
# xm block-list vm1
Vdev  BE handle state evt-ch ring-ref BE-path
769    0    0     4      6      8     /local/domain/0/backend/vbd/2/769
833    0    0     4      8      833   /local/domain/0/backend/vbd/2/833
#


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: remove_devinfo.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel