[Xen-devel] Re: [PATCH][HVM] pass-through PCI device hotplug support

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Please add more comments to your DSDT changes so it's clear what the changes
are actually for. A paragraph or two distributed around your changes would
be good, including references to the ACPI specification document where that
is useful.

Apart from that I expect the patch is fine. You can send the DSDT comments
as an incremental patch on top of this one.

 -- Keir


On 23/1/08 15:52, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> All,
> 
> This patch enables HVM guest VT-d device hotplug via a simple ACPI hotplug
> device model. Pls. have a look.
> 
> On VT-d side, it's very useful as you can dynamically assign VT-d device to a
> guest as long as it support ACPI hotplug(Linux 2.6, 2000, 2003, XP... pass the
> test).
> 
> * Usage is very simple.
> Three new commands are added:
> "xm dpci-list domid" show the current assigned vtd device, like:
> ID  domain   bus   slot   func
> 0      0x0  0x02   0x00    0x0
> 
> "xm dpci-remove" hot remove the specified vtd device by the ID, like:
> xm dpci-remove EdwinHVMDomainVtd 0
> 
> "xm dpci-insert" hot add a new vtd device, like '03:00.0':
> xm dpci-insert EdwinHVMDomainVtd 3 0 0
> 
> * Currently only 2 virtual pci slots are made as being capable of hotplug, so
> more than 2 vtd dev can't be hotplugged, but we can easily extend it in
> future.
> 
> * I reuse the pci PV driver configuration but untouch the code path since
> there 
> may be HVM pci PV driver in future. I'm not sure if the python changes are
> okay, 
> maybe you guys have some good idea.
>  
> Thanks,



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel