[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATH] ioemu: use SIGHUP instead of SIGKILL

Although this looks potentially reasonable, I'm not sure about the approach
of SIGHUPing a dom0 'proxy' process to kill an hvm stub domain. How hard
would it be to teach xend just enough about hvm stub domains to have it
directly kill the stub domain at the same time as it kills the normal hvm
domain? I think this would yield a more robust 'xm destroy' which could
handle a wider range of stub-domain-related hangs/crashes.

 -- Keir

On 4/2/08 11:07, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> The stub domain device model needs to trap the termination signal so as
> to actually destroy the stub domain.  SIGKILL can't be trapped, SIGTERM
> is caught by SDL and so may be unnoticed.  SIGHUP can be trapped and is
> not caught by SDL (and by default causes a process termination without
> core).
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> diff -r 2407a61c0d30 tools/python/xen/xend/image.py
> --- a/tools/python/xen/xend/image.py Mon Feb 04 11:04:13 2008 +0000
> +++ b/tools/python/xen/xend/image.py Mon Feb 04 11:04:32 2008 +0000
> @@ -329,7 +329,7 @@ class ImageHandler:
>              return
>          if self.pid:
>              try:
> -                os.kill(self.pid, signal.SIGKILL)
> +                os.kill(self.pid, signal.SIGHUP)
>              except OSError, exn:
>                  log.exception(exn)
>              try:
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.