[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] Disable Xen PowerNow! support on Opteron 2nd gen and earlier processors

  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
  • Date: Mon, 4 Feb 2008 15:52:22 -0600
  • Cc: Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 04 Feb 2008 13:53:17 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchfqSS0Yzu1EMucEdyNUQAWy6hiGQAC1IswAA/P2j0ABsqr4AB6NDvwABlGPxsAAWGaZgABpF1vAKGkcSAAJeuYcAB7ldPA
  • Thread-topic: [Xen-devel] [PATCH] Disable Xen PowerNow! support on Opteron 2nd gen and earlier processors

> What are the deltas when time goes backwards? Bear in mind we already
> default to being silent for backwards deltas up to 10ms. 

Largest observed delta was 36 ms; it was a bit of an outlier.
Most deltas were around 20 ms.  I totaled 45 deltas over 10 ms
in 6 days with a frequency change every 15 seconds.

I think we can do better than that.  There's lots of <1 ms
regressions happening, roughly 1 every other 4 transitions.

> The issue here could well be that if you take a timer 
> interrupt towards the
> end of a frequency change but before Xen has been told that 
> the frequency
> has changed, the time values that Xen and dom0 calculate will 
> be off by
> potentially quite a bit. It's a small window of opportunity, 
> but clearly you
> hit it a few times each day. I'm not sure how easy it is to 
> close off that
> window cleanly with the MSR twiddling being controlled from dom0...

Would turning off interrupts solve it?  It might be a bit brute
force, but there's certainly a prechange notifier event and a 
postchange notifier event to use to turn them on and off.

Alternately, the prechange event could sleep until woken by
the timer interrupt, which would increase the chance that all 
frequency changes take place at the start of an interrupt.

-Mark Langsdorf
Operating System Research Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.