[Xen-devel] Re: [PATCH] x86_emulate: fix side-effect macro call

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>]

Samuel Thibault, le Tue 05 Feb 2008 15:33:55 +0000, a écrit :
> x86_emulate: fix side-effect macro call
> Both jmp_rel and insn_fetch_type increment eip, so it's not
> compiler-safe to nest the calls.

Another way to fix it would be to change jmp_rel:

- _regs.eip += (int)(rel);
+ int _rel = (int)(rel);
+ _regs.eip += _rel;

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel