[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Remove redundant check of maximum memory size


Currently, a wrong value of maximum memory size is checked by 
_safe_set_memory() and _memory_sanity_check().  I think that the 
following codes are redundant. 

BTW, we can set current memory size of domains greater than physical 
memory size of machines by xm mem-set command.  Maximum memory size 
also is same by xm mem-max command.  Do you have a plan to make an 
error of the xm commands if memory size greater than physical memory 
size of machines was required?  Or is the behavior of the xm commands 

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,

diff -r 2a3111016f88 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Mon Feb 11 15:59:49 2008 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Tue Feb 12 15:01:46 2008 +0900
@@ -707,9 +707,6 @@ class XendDomainInfo:
         log.debug("Setting memory maximum of domain %s (%s) to %d MiB.",
                   self.info['name_label'], str(self.domid), limit)
-        if limit <= 0:
-            raise XendError('Invalid memory size')
         MiB = 1024 * 1024
         self._safe_set_memory('memory_static_max', limit * MiB)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.