Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 12/2/08 09:22, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

> I'm not sure your fix is completely safe.  Once the frontend exposed
> the shared page to the backend, it is not supposed to touch in_prod
> and out_cons, and it may only increase in_cons and out_prod.  I think
> you better do
> 
> xenkbd_disconnect_backend(info);
> + info->page->in_cons = info->page->in_prod;
> return xenkbd_connect_backend(dev, info);

The page is not exposed to the new backend until xenkbd_connect_backend().
So the originally proposed fix is correct in this regard, I think.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel