[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard

  • To: Markus Armbruster <armbru@xxxxxxxxxx>, SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 12 Feb 2008 10:09:08 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 12 Feb 2008 02:10:19 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchtX04ejN0xeNlSEdyzHgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard

On 12/2/08 09:22, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

> I'm not sure your fix is completely safe.  Once the frontend exposed
> the shared page to the backend, it is not supposed to touch in_prod
> and out_cons, and it may only increase in_cons and out_prod.  I think
> you better do
> xenkbd_disconnect_backend(info);
> + info->page->in_cons = info->page->in_prod;
> return xenkbd_connect_backend(dev, info);

The page is not exposed to the new backend until xenkbd_connect_backend().
So the originally proposed fix is correct in this regard, I think.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.