[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries

  • To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 18 Feb 2008 13:44:32 +0000
  • Delivery-date: Mon, 18 Feb 2008 05:45:12 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AchyNGPmoqLDmt4nEdykwQAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Allow 32bit PAE guests to change their L3 entries

On 18/2/08 12:32, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> adjust_guest_l3e() adds (_PAGE_USER|_PAGE_RW) to the entry, and then
> get_page_from_l3e() checks that _PAGE_USER or _PAGE_RW are not present
> for PAE guests.  get_page_from_l3e() will always fail at this point
> for PAE guests.
> Attached patch fixes this. This bug has been uncovered with NetBSD 32bit PAE
> guests.

It breaks the fast update path, and also all mod_lN_entry() functions should
probably be reorganised for consistency. I'll make these changes and apply

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.