Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 3/4/08 14:57, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

>> Yes it is needed if your patch is to work across all architectures, not just
>> x86! Your current patch is broken in this respect because you quite
>> unnecessarily define domain_to_node() and vcpu_to_node() in asm/numa.h
>> rather than xen/numa.h.
> Right you are. I fixed this below. While playing around with the
> headers, I realized that numa.h is not needed at all in
> common/page_alloc.c and common/sysctl.c. Can you confirm this? Or is
> this needed for the other architectures?

It's polite to directly include stuff you use and not depend on transitive
header inclusion, as that can be fragile.

> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> 
> 
>> Please address architectural portability and re-send the patch. Apart from
>> that I think it's just about ready to go in.
> I am just trying to install an IA64 cross compiler, but it seems this
> will take some time...

The ia64 guys will thank you for it, even if I don't require it!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel