[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH][RFC] Supporting Enlightened Windows 2008Server

>>> On Fri, Mar 7, 2008 at  8:30 AM, in message
<C3F6F3FB.1DAE5%keir.fraser@xxxxxxxxxxxxx>, Keir Fraser
<keir.fraser@xxxxxxxxxxxxx> wrote: 
> On 7/3/08 01:10, "Ky Srinivasan" <ksrinivasan@xxxxxxxxxx> wrote:
>> I agree that there is no need to isolate the shim's dependence on the base 
> Xen
>> code (xen_call_vector_t). I implemented this shim a year ago and at that 
> point
>> it was not clear what Microsoft might do with the Veridian specification.  
> So,
>> clearly some of the design choices that I made a year ago may not be the 
> right
>> choice today. However, I still think that having an intercept framework 
> where
>> one can implement Veridian specific functionality without cluttering up the
>> base Xen code is still the right approach.
> Clearly putting the Viridian hypercall shims in a different file/directory
> makes sense. But I think the shims would need to go on a diet. The TLB
> flushing implementation is a good example -- the useful extra features of
> the Viridian flush hypercall (if there are any, when partnered with Xen's
> shadow code) should be pushed into core Xen HVM TLB-flush handling code.
> Otherwise it sits out on the periphery with a correspndingly greater
> tendency to rot, and for no benefit (certainly I would strongly argue it is
> not cleaner!).
>  -- Keir


Based on the feedback I got from you and Tim, I am enclosing the next version 
of the patches to support enlightened win2008 server. Here are the changes I 
have made:

1) I have put the shim on a low calorie diet - I have gotten rid of the 
framework infrastructure and to the extent possible integrated the shim code 
with xen.

2) I have tried to cleanup the code. I am sure  more work will be needed here.

3) I am not advertising the TLB related enlightenments. We can revisit this 
later if needed.


K. Y
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: hv_tools.patch
Description: Text document

Attachment: hv_xen_base.patch
Description: Text document

Attachment: hv_xen_extension.patch
Description: Text document

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.