[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Wei, Gang" <gang.wei@xxxxxxxxx>
  • Date: Wed, 30 Apr 2008 11:27:32 +0800
  • Cc: Jan Beulich <jbeulich@xxxxxxxxxx>
  • Delivery-date: Tue, 29 Apr 2008 20:28:09 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcipEbfT7gVtCqEbTvql1WxSajh7rwBXgwEA
  • Thread-topic: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

Revising done according to Jan's comments. Resend.

Jimmy

On Monday, April 28, 2008 5:25 PM, Jan Beulich wrote:
> Some comments regarding the compat guest handling: You cannot
> validly set_xen_guest_handle() on space coming from xmalloc. It is
> the purpose of the per-vCPU argument translation page to deal with
> that (i.e. the translated arguments go into that page, subject to your
> own management of how you assign space for the individual (sub-)
> hypercall's arguments).
> 
> Further, you shouldn't manually copy fields, this should be done
> through the machine generated macros in xen/include/compat/xlat.h,
> which would require you to add the structures needing translation to
> xen/include/xlat.lst.
> 
> Jan

Attachment: xen-1-cx_base-0430.patch
Description: xen-1-cx_base-0430.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.