Re: [Xen-devel] [PATCH] Allow direct hypercalls

[John Levon <john.levon@xxxxxxx>]

On Thu, May 01, 2008 at 04:03:43PM +0100, Keir Fraser wrote:

> > # HG changeset patch
> > # User john.levon@xxxxxxx
> > # Date 1209521783 25200
> > # Node ID 9a5c6e3620d83f9354e3eedbc4ef24a7a5ad752e
> > # Parent  f477f895f78752bb9fa2e6ee6c1d09b6a8cd3230
> > Allow direct hypercalls
> > 
> > For PV guests, there's no reason to force use of the indirect hypercall
> > mechanism. Allow it. Also allow TRAP_INSTR to be used from assembly.
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> Well, I suppose there is no reason. But since the instructions are not going
> to change you could just as well just open-code them, or define your own
> macro. _ASM isn't even a macro name that we use anywhere else in the public
> headers.

We're doing our best to try and merge our tree with your upstream. I
don't quite understand why you're refusing such simple, non-intrusive
changes. Is it really good coding practice to needlessly duplicate
stuff?

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel