[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH] Enable Px/Cx related CPUID/MSR bits for dom0


  • To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Wei, Gang" <gang.wei@xxxxxxxxx>
  • Date: Tue, 6 May 2008 08:39:45 +0800
  • Delivery-date: Mon, 05 May 2008 17:41:13 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Aciucp7xXvPGFQVHQc62vzQNeMPItQAH5bLaAAyz9wAAATH80QAR7wbQ
  • Thread-topic: [PATCH] Enable Px/Cx related CPUID/MSR bits for dom0

That is ok. Please do keep X86_FEATURE_EST feature.

Jimmy

On Tuesday, May 06, 2008 12:05 AM, Keir Fraser wrote:
> I'll remove them and you can add them back in with a comment if they
turn
> out to be required.
> 
>  -- Keir
> 
> On 5/5/08 16:48, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> 
>> On Monday, May 05, 2008 5:27 PM, Keir Fraser wrote:
>>> Applied your patches, but why would you expose MWAIT as a usable
>>> feature? 
>> 
>> I can't exactly tell why. What I am sure is that X86_FEATURE_EST
should
>> be exposed, otherwise ACPI _CST method invoking in dom0 will always
>> failed. MWAIT feature & MSR_IA32_MISC_ENABLE_MONITOR_ENABLE bit are
>> exposed just in case of possible needs. If I could make sure MWAIT
>> feature & MONITOR_ENABLE are not needed, I will send patch to remove
>> them. 
>> 
>>> Maybe worth a comment explaining that, as otherwise it's not
unlikely to
>>> be cleaned up as a 'mistake' sometime in the future.
>> 
>> Ok, I will add comment after I can explain clearly.
>> 
>> Jimmy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.