Re: [Xen-devel] [PATCH] msix: revoke correct amount of msi-x related iomem

[Neil Turton <nturton@xxxxxxxxxxxxxx>]

Espen Skoglund wrote:
> +                        self.msix_entries = (message_cont_lo + \
> +                                             message_cont_hi << 8) \
> +                                             & MSIX_SIZE_MASK

That still doesn't look right to me since "+" binds tighter than "<<".
I think it needs some more parentheses around "message_cont_hi << 8", at
least if I've understood what the code's supposed to do.

Cheers, Neil.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel